Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate useDispatch with useQuery/request in src/Components/Common/** #6889

Merged
merged 16 commits into from
Jan 10, 2024
Merged

Migrate useDispatch with useQuery/request in src/Components/Common/** #6889

merged 16 commits into from
Jan 10, 2024

Conversation

rithviknishad
Copy link
Member

@rithviknishad rithviknishad commented Dec 21, 2023 •
edited
Loading

Proposed Changes

Affects

  • Fetching options in Asset Select Dropdown
  • Fetching options in Bed Select Dropdown
  • Fetching options in State, District, LocalBody Autocomplete Dropdown
  • Fetching options in Facility Locations Autocomplete Dropdown
  • Fetching options in Skill Select Dropdown
  • Fetching options in Investigation Builder of Consultation Form
  • Fetching uptime status records in Asset Availability
  • Fetching options in Facility Select dropdown

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@rithviknishad rithviknishad requested a review from a team as a code owner December 21, 2023 07:34
@netlify Netlify
Copy link

netlify bot commented Dec 21, 2023 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 32016ee
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/6596ec2333ad4100083515b6
😎 Deploy Preview https://deploy-preview-6889--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@vercel Vercel
Copy link

vercel bot commented Dec 21, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 4, 2024 5:35pm

@cypress Cypress
Copy link

cypress bot commented Dec 21, 2023 •
edited
Loading

Passing run #1830 ↗︎

0 95 0 0 Flakiness 0

Details:

Migrate `useDispatch` with `useQuery/request` in `src/Components/Common/**`
Project: CARE Commit: 32016ee1d6
Status: Passed Duration: 02:33 💡
Started: Jan 4, 2024 5:38 PM Ended: Jan 4, 2024 5:40 PM

Review all test suite changes for PR #6889 ↗︎

@nihal467
Copy link
Member

@rithviknishad fix the cypress test

@rithviknishad
Copy link
Member Author

rithviknishad commented Jan 3, 2024 •
edited
Loading

@nihal467 patient crud is failing for an unrelated reason and a parallel PR seems to be fixing it as discussed https://rebuildearth.slack.com/archives/C010GQC5UE9/p1704126513851419

The originally failing asset manage and asset create tests has been addressed.

@nihal467
Copy link
Member

nihal467 commented Jan 4, 2024

@rithviknishad
image

https://deploy-preview-6889--care-net.netlify.app/facility/fe1b9b4b-def3-488a-808a-a5776222f65b/assets/48e768c6-237a-4235-97e6-4ab63a8f04ad

  • asset uptime operational details are malfunctioning

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Jan 4, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 4, 2024

👋 Hi, @rithviknishad,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@rithviknishad rithviknishad added needs testing and removed test failed merge conflict pull requests with merge conflict labels Jan 4, 2024
@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit 197cb39 into develop Jan 10, 2024
37 of 38 checks passed
@khavinshankar khavinshankar deleted the useQuery-migrations/common branch January 10, 2024 07:58
@github-actions GitHub Actions
Copy link

@rithviknishad We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

@rithviknishad rithviknishad mentioned this pull request Jan 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khavinshankar khavinshankar khavinshankar approved these changes

Assignees
No one assigned
Labels
tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🛠️ Replace useDispatch w. useQuery/request: Common (src/Components/Common/**)
3 participants
@rithviknishad @nihal467 @khavinshankar